forked from ember-template-lint/ember-template-lint
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Option to Print Full File Paths #1
Open
rtablada
wants to merge
1,322
commits into
master
Choose a base branch
from
rt/4.3-fullpath
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upgrade-fixturify
Bumps [fixturify-project](https://github.com/stefanpenner/node-fixturify-project) from 2.1.1 to 4.1.0. - [Release notes](https://github.com/stefanpenner/node-fixturify-project/releases) - [Changelog](https://github.com/stefanpenner/node-fixturify-project/blob/master/CHANGELOG.md) - [Commits](stefanpenner/node-fixturify-project@v2.1.1...v4.1.0) --- updated-dependencies: - dependency-name: fixturify-project dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…dependabot/npm_and_yarn/fixturify-project-4.1.0
Bumps [eslint-config-prettier](https://github.com/prettier/eslint-config-prettier) from 8.4.0 to 8.5.0. - [Release notes](https://github.com/prettier/eslint-config-prettier/releases) - [Changelog](https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md) - [Commits](prettier/eslint-config-prettier@v8.4.0...v8.5.0) --- updated-dependencies: - dependency-name: eslint-config-prettier dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…dependabot/npm_and_yarn/eslint-config-prettier-8.5.0
Co-authored-by: Robert Jackson <me@rwjblue.com>
…multi-formatter
Bumps [eslint](https://github.com/eslint/eslint) from 8.10.0 to 8.11.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.10.0...v8.11.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…dependabot/npm_and_yarn/eslint-8.11.0
Bumps [eslint-plugin-unicorn](https://github.com/sindresorhus/eslint-plugin-unicorn) from 41.0.0 to 41.0.1. - [Release notes](https://github.com/sindresorhus/eslint-plugin-unicorn/releases) - [Commits](sindresorhus/eslint-plugin-unicorn@v41.0.0...v41.0.1) --- updated-dependencies: - dependency-name: eslint-plugin-unicorn dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@babel/parser](https://github.com/babel/babel/tree/HEAD/packages/babel-parser) from 7.17.3 to 7.17.8. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.17.8/packages/babel-parser) --- updated-dependencies: - dependency-name: "@babel/parser" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [release-it](https://github.com/release-it/release-it) from 14.12.5 to 14.13.1. - [Release notes](https://github.com/release-it/release-it/releases) - [Changelog](https://github.com/release-it/release-it/blob/master/CHANGELOG.md) - [Commits](release-it/release-it@14.12.5...14.13.1) --- updated-dependencies: - dependency-name: release-it dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [sort-package-json](https://github.com/keithamus/sort-package-json) from 1.54.0 to 1.55.0. - [Release notes](https://github.com/keithamus/sort-package-json/releases) - [Commits](keithamus/sort-package-json@v1.54.0...v1.55.0) --- updated-dependencies: - dependency-name: sort-package-json dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…dependabot/npm_and_yarn/sort-package-json-1.55.0 build(deps-dev): bump sort-package-json from 1.54.0 to 1.55.0
…dependabot/npm_and_yarn/release-it-14.13.1 build(deps-dev): bump release-it from 14.12.5 to 14.13.1
…fix-version Fix `--version` to actually give the right value
…plate-lint#2626) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [vm2](https://github.com/patriksimek/vm2) from 3.9.9 to 3.9.11. - [Release notes](https://github.com/patriksimek/vm2/releases) - [Changelog](https://github.com/patriksimek/vm2/blob/master/CHANGELOG.md) - [Commits](patriksimek/vm2@3.9.9...3.9.11) --- updated-dependencies: - dependency-name: vm2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…nt#2622) Bumps [eslint](https://github.com/eslint/eslint) from 8.23.0 to 8.24.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.23.0...v8.24.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [ci-info](https://github.com/watson/ci-info) from 3.3.2 to 3.4.0. - [Release notes](https://github.com/watson/ci-info/releases) - [Changelog](https://github.com/watson/ci-info/blob/master/CHANGELOG.md) - [Commits](watson/ci-info@v3.3.2...v3.4.0) --- updated-dependencies: - dependency-name: ci-info dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…emplate-lint#2627) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…late-lint#2639) * Add auto fix for simple-unless case with helpers * simplify result of `simple unless` autofix to avoid `(not (not` chain
…nt#2632) Bumps [eslint](https://github.com/eslint/eslint) from 8.23.0 to 8.25.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.23.0...v8.25.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…mplate-lint#2646) Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.19.3 to 7.19.4. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.19.4/packages/babel-traverse) --- updated-dependencies: - dependency-name: "@babel/traverse" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
ember-template-lint#2650) Bumps [eslint-plugin-import-helpers](https://github.com/Tibfib/eslint-plugin-import-helpers) from 1.2.1 to 1.3.0. - [Release notes](https://github.com/Tibfib/eslint-plugin-import-helpers/releases) - [Commits](willhoney7/eslint-plugin-import-helpers@v1.2.1...v1.3.0) --- updated-dependencies: - dependency-name: eslint-plugin-import-helpers dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
eslint-plugin-import-helpers@1 requires Node 16 or higher, which is not compatible with our node support matrix. In version 1.3.0 they added an `engines` field documenting that requirement. When using `npm@8` the `--engines-strict` flag is on by default. Ultimately, this combination of events means that `npm ci` fails with: ``` ❯ volta run --node=14.x --npm=8.10.0 npm ci npm ERR! code EBADENGINE npm ERR! engine Unsupported engine npm ERR! engine Not compatible with your version of node/npm: eslint-plugin-import-helpers@1.3.0 npm ERR! notsup Not compatible with your version of node/npm: eslint-plugin-import-helpers@1.3.0 npm ERR! notsup Required: {"node":"> 14"} npm ERR! notsup Actual: {"npm":"8.10.0","node":"v14.20.1"} npm ERR! A complete log of this run can be found in: npm ERR! /Users/rjackson/.npm/_logs/2022-10-25T20_45_44_753Z-debug-0.log ```
…remove-eslint-plugin-import-helpers Remove eslint-plugin-import-helpers
We were using `cross-env` in order to set the `--experimental-vm-modules` flag via `process.env.NODE_OPTIONS` to run `jest`. Unfortunately, this means that the `NODE_OPTIONS` that was being set in our `.github/workflows/ci.yaml` (which increases `--max-old-space-size` to 4096) is completely clobbered. This doesn't **fix** the memory issues that we are seeing with Node 18, but it does bring back a previously known good work around so that CI is "green again". Co-authored-by: Steve Calvert <steve.calvert@gmail.com>
This is just a stop gap, we need to debug why we are hitting memory issues.
…remove-cross-env
…mplate-lint#2653) Co-authored-by: Bryan Mishkin <698306+bmish@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no-duplicate-landmark-elements
false positive for non-landmark rolesVALID_ROLES
sethas-block-params
as built-in helper tono-implicit-this
ruleundefined
error message forno-link-to-positional-params
rulerequire-valid-alt-text
rule--json
option in favor of--format=json
.this.view
and@view
view
localrequire-valid-named-block-naming-format
ruleno-bare-strings
rule to includepage-title
helpernode
(Ensures all log calls includenode
ember-template-lint/ember-template-lint#2073)no-valueless-arguments
rule_internal
folder to mainhelpers
folder--fix
support foreol-last
ruleno-negated-condition
docno-negated-condition
rulescope.isLocal()
returns a booleanrequire-presentational-children
no-autofocus-attribute
ruleno-invalid-link-title
ruleyargs
dependency2-x-recommended
and add3-x-recommended
configquotes
ruleno-invalid-aria-attributes
docs/configuration.md
no-model-argument-in-route-templates
rule fromrecommended
config (Removeno-model-argument-in-route-templates
rule fromrecommended
config ember-template-lint/ember-template-lint#2315)no-dynamic-subexpression-invocations
rule fromrecommended
config (Removeno-dynamic-subexpression-invocations
rule fromrecommended
config ember-template-lint/ember-template-lint#2308)no-mut-helper
rule fromrecommended
config (Removeno-mut-helper
rule fromrecommended
config ember-template-lint/ember-template-lint#2316)block-indentation
rule (Add autofixer toblock-indentation
rule ember-template-lint/ember-template-lint#2281)block-indentation
rule (Fix false negatives withblock-indentation
rule ember-template-lint/ember-template-lint#2318)undefined
values, reordered the aria-query dependencymodifier-name-case
rule supports themodifier
helperrequire-aria-activedescendant-tabindex
no-invalid-aria-attributes
ruleformat
property in .template-lintrc.jsscope
scope
no-scope-outside-table-headings
write()
instead of deprecatedwriteSync()
in testsno-whitespace-within-word
rulerequire-context-role
to accepttable
as a valid parent role forrow
androwgroup
no-array-prototype-extensions
no-array-prototype-extensions
docsno-invalid-aria-attributes
rulerequire-lang-attribute
rule to validate attribute valuesvalidateValues
defaults tofalse