[Fix #12835] Allow global offenses to be disabled by directive comments #12838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… comments `Naming/FileName` now returns global offenses but there are quite a few projects that disable the cop with a comment. The change to global offenses broke that behaviour.
Earlopain
force-pushed
the
global-offense-directive-comment
branch
from
b0eae84
to
176e025
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12835
Naming/FileNamenow returns global offenses but there are quite a few projects that disable the cop with a comment, see https://github.com/search?q=%22rubocop%3Adisable+Naming%2FFileName%22&type=code. The change to global offenses in #12802 broke that behaviour.While this is technically a new feature I classify this as a bugfix to restore previous behaviour.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.