Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an error for rubocop -V when .rubocop.yml contains ERB #12871

Merged
merged 1 commit into from Apr 28, 2024

Conversation

Earlopain
Copy link
Contributor

The config file is allowed to include ERB syntax which was being parsed as YAML as is without being resolved.

Uses Util.silence_warnings to supress the potential warnings from check_duplication.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

The config file is allowed to include ERB syntax which was being
parsed as YAML as is without being resolved
@bbatsov bbatsov merged commit 81adab5 into rubocop:master Apr 28, 2024
33 checks passed
@bbatsov
Copy link
Collaborator

bbatsov commented Apr 28, 2024

Looks good to me. Thanks!

@Earlopain Earlopain deleted the rubocop-V-error branch April 28, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants