Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress Interrupt exception for LSP #12886

Merged
merged 1 commit into from May 7, 2024

Conversation

koic
Copy link
Member

@koic koic commented May 6, 2024

This PR suppresses the following backtrace of Interrupt exception for LSP:

Before

$ bundle exec rubocop --lsp
^C/Users/koic/.rbenv/versions/3.4-dev/lib/ruby/gems/3.4.0+0/gems/language_server-protocol-3.17.0.3/
lib/language_server/protocol/transport/io/reader.rb:16:in 'IO#gets': Interrupt
from /Users/koic/.rbenv/versions/3.4-dev/lib/ruby/gems/3.4.0+0/gems/language_server-protocol-3.17.0.3/
lib/language_server/protocol/transport/io/reader.rb:16:in 'LanguageServer::Protocol::Transport::Io::Reader#read'
        from /Users/koic/src/github.com/rubocop/rubocop/lib/rubocop/lsp/server.rb:35:in 'RuboCop::LSP::Server#start'
(snip)

After

$ bundle exec rubocop --lsp
^C
Exiting...

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

This PR suppresses the following backtrace of `Interrupt` exception for LSP:

## Before

```console
$ bundle exec rubocop --lsp
^C/Users/koic/.rbenv/versions/3.4-dev/lib/ruby/gems/3.4.0+0/gems/language_server-protocol-3.17.0.3/
lib/language_server/protocol/transport/io/reader.rb:16:in 'IO#gets': Interrupt
from /Users/koic/.rbenv/versions/3.4-dev/lib/ruby/gems/3.4.0+0/gems/language_server-protocol-3.17.0.3/
lib/language_server/protocol/transport/io/reader.rb:16:in 'LanguageServer::Protocol::Transport::Io::Reader#read'
        from /Users/koic/src/github.com/rubocop/rubocop/lib/rubocop/lsp/server.rb:35:in 'RuboCop::LSP::Server#start'
(snip)
```

## After

```console
$ bundle exec rubocop --lsp
^C
Exiting...
```
@koic koic merged commit 9845aff into rubocop:master May 7, 2024
33 checks passed
@koic koic deleted the suppress_interrupt_exception_for_lsp branch May 7, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant