Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linecache only for JRuby uses entries which only exists on String in 1.8... #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

enebo
Copy link
Contributor

@enebo enebo commented Dec 14, 2012

... (Enumerable no longer mixed into string). This adds a reasonably compatible version.

I admit this is a little crappy. I could try and submit this to linecache, but linecache is stated that it will not work in 1.9, but we don't actually use the native extension part of linecache in JRuby. Adding this tiny monkey patch fixes things adequately for JRuby. Also, this version of ruby-debug is nearly as green as the 1.8 version, so I would like to minimally patch this gem for JRuby can have a working ruby-debug gem which works regardless of which mode is used: --1.8,--1.9,or --2.0.

…1.8 (Enumerable no longer mixed into string). This adds a reasonably compatible version.
@jfirebaugh
Copy link
Member

That's a pretty awkward monkey patch.

I wonder how hard it would be to dump the linecache dependency entirely. It seems to be a headache.

@enebo
Copy link
Contributor Author

enebo commented Dec 14, 2012

Yeah. I tried to make something which would behave like entries in 1.8 for 1.9 mode but it does suck. I also thought about removing the dependency but the easiest way would be to use jruby-parser gem and that seemed somewhat heavy handed.

The second issue with linecache is there is a linecache and a linecache19 now :(

@denofevil
Copy link
Member

We can start with removing linecache dependency from ruby-debug-base. It's really needed only in ruby-debug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants