fix: Use mount_path to narrow down urls_for #924
Merged
+15
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chibicco
commented
Apr 21, 2024
chibicco
force-pushed
the
feat-mount_path-to-narrow-down-urls_for
branch
from
670a236
to
e8d0776
Compare
chibicco
commented
Apr 21, 2024
chibicco
force-pushed
the
feat-mount_path-to-narrow-down-urls_for
branch
from
86231f8
to
ac8b4d2
Compare
chibicco
force-pushed
the
feat-mount_path-to-narrow-down-urls_for
branch
from
ac8b4d2
to
078bb34
Compare
|
Thank you for your review : ) |
chibicco
force-pushed
the
feat-mount_path-to-narrow-down-urls_for
branch
from
078bb34
to
5afe75a
Compare
LeFnord
approved these changes
Apr 26, 2024
diegodorado
reviewed
Apr 30, 2024
| @@ -95,7 +95,7 @@ def make_request(url) | |||
| def urls_for(api_class) | |||
| api_class.routes | |||
| .map(&:path) | |||
| .select { |e| e.include?('doc') } | |||
There was a problem hiding this comment.
mmh, it is gone … what do you mean?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Hello, thanks for this useful library !
When you run
rake oapi:fetch, All endpoints that include the path name doc will be caught.Narrow down the target path using mount_path.
Related items