Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rake annotate #1400

Closed
wants to merge 3 commits into from
Closed

rake annotate #1400

wants to merge 3 commits into from

Conversation

ParadoxV5
Copy link
Contributor

The rest of rake annotate changes from a184eda & dc59809

The rest of `rake annotate` changes from a184eda & dc59809
@ParadoxV5 ParadoxV5 marked this pull request as draft July 28, 2023 01:22
@ParadoxV5
Copy link
Contributor Author

The files were generated with Ruby 3.2.2.

@soutaro
Copy link
Member

soutaro commented Aug 11, 2023

@ParadoxV5 Can you explain where the diffs come from? (It looks like CI generates the old docs.)

@ParadoxV5
Copy link
Contributor Author

I’ve identified the deviation. When I ran bundle exec rake annotate, the script fails at the line
bundle exec rbs annotate --no-system --no-gems --no-site --no-home -d /tmp/rdoc-3.2.2 core stdlib:

bundler: failed to load command: rbs (/usr/local/lib/ruby/gems/3.2.0/bin/rbs)
<internal:/usr/local/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:37:in `require': cannot load such file -- rbs_extension (LoadError)

Thus in order to publish the PRs associated with the aforementioned commits, I ran
rbs annotate --no-system --no-gems --no-site --no-home -d /tmp/rdoc-3.2.2 core stdlib
without bundle exec. The more up-to-date gems in my system may be the cause of these extra diffs.

Since you have prompted a further investigation into these, I have retraced the steps. I noticed that replacing rbs with exe/rbs does not make a difference. That is, the LoadError still raises with a manually run of
bundle exec exe/rbs annotate --no-system --no-gems --no-site --no-home -d /tmp/rdoc-3.2.2 core stdlib,
and the diffs still generate with
exe/rbs annotate --no-system --no-gems --no-site --no-home -d /tmp/rdoc-3.2.2 core stdlib.

@ParadoxV5
Copy link
Contributor Author

Checking the bundle install logs, I noticed that every fetch/install line is for older versions of dependent gems. What’s the dep update guideline for this project?

@soutaro
Copy link
Member

soutaro commented Aug 18, 2023

Thanks for the investigation. It seems because of the version difference between your local gems and locked gems.

I recently found the rbs annotate code depending on RDoc has some potential problems. And plan to fix them in next version.

@ParadoxV5
Copy link
Contributor Author

Obsolete, except maybe #issuecomment-1683366042

@ParadoxV5 ParadoxV5 closed this May 1, 2024
@ParadoxV5 ParadoxV5 deleted the rake-annotate branch May 1, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants