New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Float #1745

Open

sampersand wants to merge 1 commit into ruby:master from sampersand:swesterman/24-01-28/Float

Contributor

sampersand commented Feb 5, 2024 •

edited

This updates Float:

Move constants inside it
Added Numeric::_XXX interfaces for operators, as well as Numeric::_Coerce
Float#{+,-,*,/,%,**,<,>,<=,>=,<=>,divmod,quo}: Now uses Numeric::_XXX methods.
Multiple methods (eg Float#=== and Float#fdiv) are now aliases
Revamped Float#round.
Moved all functions not defined on Float, but rather Numeric, to the bottom of the function and marked them as deprecated
Overhauled the tests

sampersand force-pushed the swesterman/24-01-28/Float branch from d83053b to d22c688 Compare

February 6, 2024 00:30

sampersand changed the title ~~WIP update Float~~ Update Float

sampersand marked this pull request as ready for review

February 6, 2024 00:37

sampersand force-pushed the swesterman/24-01-28/Float branch 5 times, most recently from d4feecf to 70628db Compare

February 8, 2024 23:36

sampersand mentioned this pull request

Update Rational #1754

Open


          Update Float's definitions

b261814

sampersand force-pushed the swesterman/24-01-28/Float branch from 70628db to b261814 Compare

February 9, 2024 22:32

Member

soutaro commented Jun 5, 2024

The changes look good, but it doesn't work well with the current version of Steep. It is a kind of bug of Steep, so I will fix the problem and then merge this PR, to avoid unnecessary type checking issues at the end users side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment