Embedded racc parser for portability #1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: |
eregon
changed the title
|
For those who wonders how this impacts RDoc license, there should be no impact IMHO, because Racc explicitly allows to use the embedded parser with whatever license: https://github.com/ruby/racc/blob/5eb07b28bfb3e193a1cac07798fe7be7e1e246c4/lib/racc/parser.rb#L8-L10 And FTR, maybe this could be mentioned somewhere in LEGAL.rdoc |
st0012
added a commit
to ruby/irb
that referenced
this pull request
Nov 6, 2023
In ruby/rdoc#1019 RDoc starts embedding Racc. But Racc in Ruby 3.3 will not be a default gem anymore, which requires explicit declaration in Gemfile.
tompng
pushed a commit
to ruby/irb
that referenced
this pull request
Nov 6, 2023
In ruby/rdoc#1019 RDoc starts embedding Racc. But Racc in Ruby 3.3 will not be a default gem anymore, which requires explicit declaration in Gemfile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
rdoc/rd/inline_parser.rbandrdoc/rd/block_parser.rbhaverequire "racc/parser"for external dependency. We should avoid to depend it for RD parser.