Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop code for old versions #1038

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Drop code for old versions #1038

merged 2 commits into from
Sep 5, 2023

Conversation

nobu
Copy link
Member

@nobu nobu commented Sep 5, 2023

We have already dropped the support for 2.5 or earlier because of CVE-2021-31799.

@hsbt
Copy link
Member

hsbt commented Sep 5, 2023

Should we also bump up required_ruby_version to 2.7?

https://github.com/ruby/rdoc/blob/master/rdoc.gemspec#L233

@nobu nobu merged commit 0d10f46 into ruby:master Sep 5, 2023
21 checks passed
@nobu nobu deleted the drop-code-for-old-versions branch September 5, 2023 01:14
@nobu nobu temporarily deployed to github-pages September 5, 2023 01:15 — with GitHub Actions Inactive
@nobu
Copy link
Member Author

nobu commented Sep 5, 2023

Dropped 2.5 and earlier because of the security issue, but I'm not sure about 2.6.
And why 2.7 not 3.0, is 2.7 needed to be supported still?

@hsbt
Copy link
Member

hsbt commented Sep 5, 2023 •
edited

rails/rails still support Ruby 2.7 at main branch. If we drop Ruby 2.7 support from rdoc and release it, it will break rails CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nobu @hsbt