Fix NoMethodError for tokens_to_s method
#1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling `tokens_to_s` gets an error if `token_stream` is nil: ``` undefined method `compact' for nil:NilClass (NoMethodError) ``` So, fall back to an empty array if `@token_stream` is nil.
toshimaru
added a commit
to toshimaru/sdoc
that referenced
this pull request
Nov 17, 2023
Due to the change in ruby/rdoc#1055, `token_stream` returns empty Array instead of `nil`, so update check logic for `token_stream` existence.
toshimaru
added a commit
to toshimaru/sdoc
that referenced
this pull request
Nov 17, 2023
Due to the change in ruby/rdoc#1055, `token_stream` returns empty Array instead of `nil`, so update check logic for `token_stream` existence.
|
This seems like a breaking change, as demonstrated by rails/sdoc#346.
It is easy to handle this change in SDoc, but I wanted to point it out. |
toshimaru
added a commit
to toshimaru/rdoc
that referenced
this pull request
Nov 19, 2023
The change in ruby#1055 might be a breaking change. So, just simply return `token_stream.to_s` when it's nil
toshimaru
added a commit
to toshimaru/rdoc
that referenced
this pull request
Nov 19, 2023
The change in ruby#1055 might be a breaking change. So, just simply return `token_stream.to_s` when it's nil
toshimaru
added a commit
to toshimaru/rdoc
that referenced
this pull request
Nov 21, 2023
The change in ruby#1055 might be a breaking change. So, just simply wrap `token_stream` with `Array` Co-authored-by: Jonathan Hefner <jonathan@hefner.pro>
hsbt
pushed a commit
that referenced
this pull request
Dec 5, 2023
The change in #1055 might be a breaking change. So, just simply wrap `token_stream` with `Array` Co-authored-by: Jonathan Hefner <jonathan@hefner.pro>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
tokens_to_sgets an error iftoken_streamis nil:So, fall back to an empty array if
@token_streamisnil.The case
token_streamis nil