Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not enable ReadlineInputMethod for dumb terminal #10634

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Do not enable ReadlineInputMethod for dumb terminal #10634

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eda8fbd
Do not enable ReadlineInputMethod for dumb terminal
zonuexe Apr 25, 2024
b27eefa
Merge branch 'master' into fix/irb-im-accept-dumb
zonuexe Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/irb/context.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ def initialize(irb, workspace = nil, input_method = nil)
@io = nil
case use_multiline?
when nil
if STDIN.tty? && IRB.conf[:PROMPT_MODE] != :INF_RUBY && !use_singleline?
if STDIN.tty? && IRB.conf[:PROMPT_MODE] != :INF_RUBY && !use_singleline? && ENV['TERM'] != 'dumb'
# Both of multiline mode and singleline mode aren't specified.
@io = RelineInputMethod.new(build_completor)
else
Expand All @@ -100,7 +100,7 @@ def initialize(irb, workspace = nil, input_method = nil)
case use_singleline?
when nil
if (defined?(ReadlineInputMethod) && STDIN.tty? &&
IRB.conf[:PROMPT_MODE] != :INF_RUBY)
IRB.conf[:PROMPT_MODE] != :INF_RUBY) && ENV['TERM'] != 'dumb'
@io = ReadlineInputMethod.new
else
@io = nil
Expand Down