Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macos bug deleting too many files #10699

Merged
merged 1 commit into from
May 26, 2024

Commits on May 24, 2024

  1. Fix macos bug deleting too many files

    Since ruby#10209 we've been noticing that on macos after running `make
    clean` the `coroutine/arm64/Context.S` file is missing, causing
    subsequent make calls to fail because `Context.S` is needed to build
    `Context.o`.
    
    The reason this is happening is because macos is case-insensitive so the
    `.s` looks for `coroutine/arm64/Context.s` and finds
    `coroutine/arm64/Context.s`. This does not happen on linux because the
    filesystem is case sensitive.
    
    I attempted to use `find` because it is case sensitive regardless of
    filesystem, but it was a lot slower than `rm` since we can't pass
    multiple file names the same way to `find`.
    
    Reverting this small part of ruby#10209 fixes the issue for macos and it
    wasn't clear that those changes were strictly necessary for the rest of
    the PR.
    
    We changed the original code to use `rm` instead of `delete` because it
    is not standarized on POSIX.
    eileencodes authored and ioquatix committed May 24, 2024
    Configuration menu
    Copy the full SHA
    1e8db06 View commit details
    Browse the repository at this point in the history