mkmf: Log stderr output in xsystem method #6300
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsbt
force-pushed
the
sh-mkmf-xcommand-stderr
branch
from
f358e6c
to
3c608b7
Compare
hsbt
force-pushed
the
sh-mkmf-xcommand-stderr
branch
from
3c608b7
to
c5bd6de
Compare
stanhu
force-pushed
the
sh-mkmf-xcommand-stderr
branch
from
cfc1146
to
286b0bf
Compare
Previously any stderr output used in `xsystem` would be discarded, making debugging a little more difficult if something failed. Use `Open3.capture2e` instead of `IO.popen`.
stanhu
force-pushed
the
sh-mkmf-xcommand-stderr
branch
from
286b0bf
to
c4fd648
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously any stderr output used in
xsystemwould be discarded,making debugging a little more difficult if something failed. Use
Open3.capture2einstead ofIO.popen.