Fix timing issue where a disconnected node is being requested & returned #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous solution had still some leeway for timing issues, leading to intermittent failing specs (albeit rarely)
|
I am facing a similar issue in my tests. It will occasionally fail. However never when I do a While I only did very minimal testing I was not able to reproduce this bug with this patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue outlined in rubycdp/cuprite#239.
I fixed this initially by adding a
node.isConnectedcheck toCuprite.isVisible, but after digging a bit deeper, it seems that the node get disconnected between thecallfor_cuprite.findand itshandle_response. In this case we request a node viaDOM.requestNodewhich is not connected to the document anymore and does not seem to get obsolete (subsequent commands such as #visible? never raiseNodeNotFoundError).I'm not sure this is the right place, maybe adding a disconnected check in Cuprite
Nodemight be a bit less invasive. Please tell me what you think.