Use Java ProcessBuilder for JRuby process launch #401
Conversation
|
For JRuby implementation we need to add it to matrix, I wouldn't merge just one bit of the process I believe it's much harder than this. Can you add it to matrix? |
Sorry, I missed the reference. Do you mean their communications channel on Matrix? |
|
Oh I meant to https://github.com/rubycdp/ferrum/blob/main/.github/workflows/tests.yml |
@route I have added |
|
Looks like at some point connection to browser crashes and then after that all tests failing |
|
@jemelyah could you please rebase against latest main branch? |
jemelyah
force-pushed
the
issue_400/jruby_process_launch
branch
from
191a9f4
to
7ac8b6d
Compare
|
@route just pushed the merged changes |
|
On it |
|
@route I've updated the code to reflect latest changes in Process class; however, my local tests are still failing, so I'll need to figure out how to handle the problems. |
|
Added JRuby to the matrix once again, lost it somewhere. |
| @@ -33,7 +33,7 @@ | |||
| expect(frame.url).to end_with("/ferrum/get_cookie") | |||
| end | |||
|
|
|||
| it "finds main frame properly" do | |||
| it "finds main frame properly", skip: Ferrum::Utils::Platform.jruby? do | |||
There was a problem hiding this comment.
JRuby populates browser.pages differently, hece the lookup in this test does not work. Maybe it is necessary to update the test here to fit both rubies.
|
@route I was finally able to get the tests going locally, by redirecting the process output to the buffered reader instead of a file. |
|
@jemelyah how long does it take to tests to pass locally? |
|
I cannot test it on windows but I cannot even install gems on jruby 9.4.5.0 (3.1.4) 2023-11-02 1abae2700f Java HotSpot(TM) 64-Bit Server VM 19.0.1+10-21 on 19.0.1+10-21 +jit [arm64-darwin] on my mac. It's failing. |
References #400.
For the JRuby implementations, use Java ProcessBuilder to redirect Chrome process output to a specific file instead of stdout.