Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Support all Ruby 2.7 for now #453

Merged
merged 1 commit into from
Mar 19, 2024
Merged

fix: Support all Ruby 2.7 for now #453

merged 1 commit into from
Mar 19, 2024

Conversation

route
Copy link
Member

@route route commented Mar 19, 2024

Ruby syntax ... was added not for all 2.7 versions. Let's fallback for now to old syntax.

Ruby syntax `...` was added not for all 2.7 versions. Let's fallback for now to old syntax.
@route route merged commit 6df4ed6 into main Mar 19, 2024
7 checks passed
@route route deleted the old-syntax branch March 19, 2024 08:31
@erickguan
Copy link
Contributor

Hey! Do you consider bumping to newer ruby versions? Ruby 3.1 is end of life next week or so. Other projects, e.g. rails, start to require 3.1.

This would allow using newer Ruby syntax. Additionally, you could build a new release and then bump the required version.

@route
Copy link
Member Author

route commented Mar 19, 2024

Newer ruby syntax is not a requirement now for ferrum. There are still projects that still use 2.7.
I will definitely in a couple of releases do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants