Make buttons easier to read #966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
approved these changes
Dec 11, 2022
There was a problem hiding this comment.
I'm neutral on the appearance, but if this one is more accessible, let's do it!
@tnir This is what you proposed, right?
Thanks so much @gustavothecoder!
tnir
added
architecture/legacy or broken
tnir
approved these changes
Dec 11, 2022
There was a problem hiding this comment.
The improved appearance looks good to me as well and I am happy to remove tweaks I introduced in #681 before 2023 🎉
Thanks @gustavothecoder for addressing this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
Closes #684
What is your fix for the problem, implemented in this PR?
I changed the
.btn-primarycolors to#0D7FA5and#0A6A8A, this colors provide a contrast ration of 4.56:1 and 6.1:1, respectively.I also renamed the file
_bootstrap-overrides.scssto_bootstrap-variable-overrides.scss, and created the file_bootstrap-class-overrides.scss, this modifications is just to improve the code organization.Screenshots
Before
After
Original colors with black text (just for comparison)
*The first button has the hover effect active.
Why did you choose this fix out of the possible options?
I chose this fix because it was already discussed before.