New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add funding_uri
metadata field to gemspec
#3060
Conversation
@bundlerbot r+ |
3060: Add `donation_uri` metadata field to gemspec r=bronzdoc a=colby-swandale # Description: I want to add a new metadata field to the gemspec called `donation_uri` for the purpose of linking a page which users can view on how to donate to/sponsor gem authors. With the introduction of [Github Sponsors](https://github.com/sponsors), [Tidlelift](https://tidelift.com/), [Open Collective](https://opencollective.com) & [Patreon](https://www.patreon.com/), donating or sponsoring a developer is now super easy and streamlined. I hope by adding this field to accomplish a number of goals: * Similar to npmjs.org, we add a button/ui element to the gem page on rubygems.org to link visitors to the given donation uri. * Encourage tooling to be built to list information about how to donate to gem authors for a given Gemfile, Gemfile.lock. (similar to the new `npm fund` command npm/cli#273) * Encourage more maintainers to signup and receive sponsorship for their work # Tasks: - [ ] Describe the problem / feature - [ ] Write tests - [ ] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). Co-authored-by: Colby Swandale <me@colby.fyi>
Build failed
|
@bundlerbot retry |
3060: Add `donation_uri` metadata field to gemspec r=bronzdoc a=colby-swandale # Description: I want to add a new metadata field to the gemspec called `donation_uri` for the purpose of linking a page which users can view on how to donate to/sponsor gem authors. With the introduction of [Github Sponsors](https://github.com/sponsors), [Tidlelift](https://tidelift.com/), [Open Collective](https://opencollective.com) & [Patreon](https://www.patreon.com/), donating or sponsoring a developer is now super easy and streamlined. I hope by adding this field to accomplish a number of goals: * Similar to npmjs.org, we add a button/ui element to the gem page on rubygems.org to link visitors to the given donation uri. * Encourage tooling to be built to list information about how to donate to gem authors for a given Gemfile, Gemfile.lock. (similar to the new `npm fund` command npm/cli#273) * Encourage more maintainers to signup and receive sponsorship for their work # Tasks: - [ ] Describe the problem / feature - [ ] Write tests - [ ] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). Co-authored-by: Colby Swandale <me@colby.fyi>
@colby-swandale bundler tests are failing with this change 😬 |
Build failed
|
I am lost, what exactly is failing here? |
Master is failing, it's unrelated to this change. I'll fix it today. |
f896322
to
6c3cd95
Compare
Ah, I opened a very similar process in rubygems/rfcs#22 for a Bundler change. Great minds etc etc. I wanted to ask, would you mind if the argument here was changed from
|
6c3cd95
to
819c784
Compare
donation_uri
metadata field to gemspecfunding_uri
metadata field to gemspec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @colby-swandale!
@bundlerbot merge |
3060: Add `funding_uri ` metadata field to gemspec r=bronzdoc a=colby-swandale # Description: I want to add a new metadata field to the gemspec called `donation_uri` for the purpose of linking a page which users can view on how to donate to/sponsor gem authors. With the introduction of [Github Sponsors](https://github.com/sponsors), [Tidlelift](https://tidelift.com/), [Open Collective](https://opencollective.com) & [Patreon](https://www.patreon.com/), donating or sponsoring a developer is now super easy and streamlined. I hope by adding this field to accomplish a number of goals: * Similar to npmjs.org, we add a button/ui element to the gem page on rubygems.org to link visitors to the given donation uri. * Encourage tooling to be built to list information about how to donate to gem authors for a given Gemfile, Gemfile.lock. (similar to the new `npm fund` command npm/cli#273) * Encourage more maintainers to signup and receive sponsorship for their work # Tasks: - [ ] Describe the problem / feature - [ ] Write tests - [ ] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). Co-authored-by: Colby Swandale <me@colby.fyi>
@bundlerbot retry |
Already running a review |
Build failed
|
@bundlerbot retry |
3060: Add `funding_uri ` metadata field to gemspec r=bronzdoc a=colby-swandale # Description: I want to add a new metadata field to the gemspec called `funding_uri` for the purpose of linking a page which users can view on how to donate to/sponsor gem authors. With the introduction of [Github Sponsors](https://github.com/sponsors), [Tidlelift](https://tidelift.com/), [Open Collective](https://opencollective.com) & [Patreon](https://www.patreon.com/), donating or sponsoring a developer is now super easy and streamlined. I hope by adding this field to accomplish a number of goals: * Similar to npmjs.org, we add a button/ui element to the gem page on rubygems.org to link visitors to the given donation uri. * Encourage tooling to be built to list information about how to donate to gem authors for a given Gemfile, Gemfile.lock. (similar to the new `npm fund` command npm/cli#273) * Encourage more maintainers to signup and receive sponsorship for their work # Tasks: - [ ] Describe the problem / feature - [ ] Write tests - [ ] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). Co-authored-by: Colby Swandale <me@colby.fyi>
Build succeeded
|
Just wondering, do I expect to see this on the sidebar on rubygems.org? |
We haven't added a button to RubyGems.org yet. PRs welcome. |
I've just opened a PR to add this: rubygems/rubygems.org#2522 |
For more information: - rubygems/rubygems#3390 - rubygems/rubygems#3060
Description:
I want to add a new metadata field to the gemspec called
funding_uri
for the purpose of linking a page which users can view on how to donate to/sponsor gem authors.With the introduction of Github Sponsors, Tidlelift, Open Collective & Patreon, donating or sponsoring a developer is now super easy and streamlined. I hope by adding this field to accomplish a number of goals:
npm fund
command Add fund subcommand npm/cli#273)Tasks:
I will abide by the code of conduct.