Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add funding_uri metadata field to gemspec #3060

Merged
2 commits merged into from Jan 31, 2020
Merged

Add funding_uri metadata field to gemspec #3060

2 commits merged into from Jan 31, 2020

Conversation

colby-swandale
Copy link
Member

@colby-swandale colby-swandale commented Dec 30, 2019

Description:

I want to add a new metadata field to the gemspec called funding_uri for the purpose of linking a page which users can view on how to donate to/sponsor gem authors.

With the introduction of Github Sponsors, Tidlelift, Open Collective & Patreon, donating or sponsoring a developer is now super easy and streamlined. I hope by adding this field to accomplish a number of goals:

  • Similar to npmjs.org, we add a button/ui element to the gem page on rubygems.org to link visitors to the given donation uri.
  • Encourage tooling to be built to list information about how to donate to gem authors for a given Gemfile, Gemfile.lock. (similar to the new npm fund command Add fund subcommand npm/cli#273)
  • Encourage more maintainers to signup and receive sponsorship for their work

Tasks:

  • Describe the problem / feature
  • Write tests
  • Write code to solve the problem
  • Get code review from coworkers / friends

I will abide by the code of conduct.

@bronzdoc
Copy link
Member

@bundlerbot r+

ghost pushed a commit that referenced this pull request Dec 31, 2019
3060: Add `donation_uri` metadata field to gemspec r=bronzdoc a=colby-swandale

# Description:

I want to add a new metadata field to the gemspec called `donation_uri` for the purpose of linking a page which users can view on how to donate to/sponsor gem authors.

With the introduction of [Github Sponsors](https://github.com/sponsors), [Tidlelift](https://tidelift.com/), [Open Collective](https://opencollective.com) & [Patreon](https://www.patreon.com/), donating or sponsoring a developer is now super easy and streamlined. I hope by adding this field to accomplish a number of goals:

* Similar to npmjs.org, we add a button/ui element to the gem page on rubygems.org to link visitors to the given donation uri.
* Encourage tooling to be built to list information about how to donate to gem authors for a given Gemfile, Gemfile.lock. (similar to the new `npm fund` command npm/cli#273)
* Encourage more maintainers to signup and receive sponsorship for their work

# Tasks:

- [ ] Describe the problem / feature
- [ ] Write tests
- [ ] Write code to solve the problem
- [ ] Get code review from coworkers / friends

I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).


Co-authored-by: Colby Swandale <me@colby.fyi>
@ghost
Copy link

ghost commented Dec 31, 2019

Build failed

  • ubuntu (2.4.x, bundler)
  • ubuntu (2.5.x, bundler)
  • ubuntu (2.6.x, bundler)
  • ubuntu_rvm (jruby-9.2.9.0)
  • ubuntu_rvm (ruby-head)

@bronzdoc
Copy link
Member

@bundlerbot retry

ghost pushed a commit that referenced this pull request Dec 31, 2019
3060: Add `donation_uri` metadata field to gemspec r=bronzdoc a=colby-swandale

# Description:

I want to add a new metadata field to the gemspec called `donation_uri` for the purpose of linking a page which users can view on how to donate to/sponsor gem authors.

With the introduction of [Github Sponsors](https://github.com/sponsors), [Tidlelift](https://tidelift.com/), [Open Collective](https://opencollective.com) & [Patreon](https://www.patreon.com/), donating or sponsoring a developer is now super easy and streamlined. I hope by adding this field to accomplish a number of goals:

* Similar to npmjs.org, we add a button/ui element to the gem page on rubygems.org to link visitors to the given donation uri.
* Encourage tooling to be built to list information about how to donate to gem authors for a given Gemfile, Gemfile.lock. (similar to the new `npm fund` command npm/cli#273)
* Encourage more maintainers to signup and receive sponsorship for their work

# Tasks:

- [ ] Describe the problem / feature
- [ ] Write tests
- [ ] Write code to solve the problem
- [ ] Get code review from coworkers / friends

I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).


Co-authored-by: Colby Swandale <me@colby.fyi>
@bronzdoc
Copy link
Member

bronzdoc commented Dec 31, 2019

@colby-swandale bundler tests are failing with this change 😬

@ghost
Copy link

ghost commented Dec 31, 2019

Build failed

  • install (jruby-9.2.9.0)
  • ubuntu (2.4.x, bundler)
  • ubuntu (2.5.x, bundler)
  • ubuntu (2.6.x, bundler)

@colby-swandale
Copy link
Member Author

I am lost, what exactly is failing here?

@deivid-rodriguez
Copy link
Member

Master is failing, it's unrelated to this change. I'll fix it today.

@gjtorikian
Copy link
Contributor

Ah, I opened a very similar process in rubygems/rfcs#22 for a Bundler change. Great minds etc etc.

I wanted to ask, would you mind if the argument here was changed from donation_uri to funding_uri? The reason is as follows:

  • Donation has the implication of sounding like a gift, something that is not mandatory. I think larger businesses in particular need to wrap their heads around the idea that while open source is free as in beer, there is a very real mental/time cost to the maintainers running the projects. Asking for donations implies that maintainers are willing to keep doing the work for free, and any monetary contribution is "just nice". By now, all of us recognize that our work has value--otherwise companies wouldn't build businesses using the gems we give away. We should be more confident in stating that, yeah, money is actually pretty useful for us to survive.
  • Funding has the implication that you're actually supporting a project; it is a continuous act that recognizes the value of the work and the importance of it for the person giving the money. I think sponsorship_uri gets this point across, too; but funding also aligns exactly with NPM's terminology, and as much as possible, open source communities across languages should unite on this cause.

@bronzdoc bronzdoc changed the title Add donation_uri metadata field to gemspec Add funding_uri metadata field to gemspec Jan 31, 2020
Copy link
Member

@bronzdoc bronzdoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @colby-swandale!

@bronzdoc
Copy link
Member

@bundlerbot merge

ghost pushed a commit that referenced this pull request Jan 31, 2020
3060: Add `funding_uri ` metadata field to gemspec r=bronzdoc a=colby-swandale

# Description:

I want to add a new metadata field to the gemspec called `donation_uri` for the purpose of linking a page which users can view on how to donate to/sponsor gem authors.

With the introduction of [Github Sponsors](https://github.com/sponsors), [Tidlelift](https://tidelift.com/), [Open Collective](https://opencollective.com) & [Patreon](https://www.patreon.com/), donating or sponsoring a developer is now super easy and streamlined. I hope by adding this field to accomplish a number of goals:

* Similar to npmjs.org, we add a button/ui element to the gem page on rubygems.org to link visitors to the given donation uri.
* Encourage tooling to be built to list information about how to donate to gem authors for a given Gemfile, Gemfile.lock. (similar to the new `npm fund` command npm/cli#273)
* Encourage more maintainers to signup and receive sponsorship for their work

# Tasks:

- [ ] Describe the problem / feature
- [ ] Write tests
- [ ] Write code to solve the problem
- [ ] Get code review from coworkers / friends

I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).


Co-authored-by: Colby Swandale <me@colby.fyi>
@colby-swandale
Copy link
Member Author

@bundlerbot retry

@ghost
Copy link

ghost commented Jan 31, 2020

Already running a review

@ghost
Copy link

ghost commented Jan 31, 2020

Build failed

  • ubuntu_rvm (jruby-9.2.9.0)
  • ubuntu_rvm (ruby-head)

@colby-swandale
Copy link
Member Author

@bundlerbot retry

ghost pushed a commit that referenced this pull request Jan 31, 2020
3060: Add `funding_uri ` metadata field to gemspec r=bronzdoc a=colby-swandale

# Description:

I want to add a new metadata field to the gemspec called `funding_uri` for the purpose of linking a page which users can view on how to donate to/sponsor gem authors.

With the introduction of [Github Sponsors](https://github.com/sponsors), [Tidlelift](https://tidelift.com/), [Open Collective](https://opencollective.com) & [Patreon](https://www.patreon.com/), donating or sponsoring a developer is now super easy and streamlined. I hope by adding this field to accomplish a number of goals:

* Similar to npmjs.org, we add a button/ui element to the gem page on rubygems.org to link visitors to the given donation uri.
* Encourage tooling to be built to list information about how to donate to gem authors for a given Gemfile, Gemfile.lock. (similar to the new `npm fund` command npm/cli#273)
* Encourage more maintainers to signup and receive sponsorship for their work

# Tasks:

- [ ] Describe the problem / feature
- [ ] Write tests
- [ ] Write code to solve the problem
- [ ] Get code review from coworkers / friends

I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).


Co-authored-by: Colby Swandale <me@colby.fyi>
@ghost
Copy link

ghost commented Jan 31, 2020

Build succeeded

  • ubuntu (2.6.x, bundler)
  • ubuntu_lint
  • ubuntu_bundler_master (2.6.x)
  • windows (2.6.x)
  • ubuntu (2.6.x, rubygems)
  • install (2.5.7)
  • ubuntu_rvm (ruby-head)
  • install (2.4.9)
  • ubuntu_rvm (2.3.8)
  • install (2.6.5)
  • ubuntu_rvm (jruby-9.2.9.0)
  • macos (2.4.x)
  • install (2.3.8)
  • ruby_master
  • ubuntu (2.4.x, rubygems)
  • ubuntu (2.5.x, bundler)
  • ubuntu (2.4.x, bundler)
  • install (jruby-9.2.9.0)
  • macos (2.5.x)
  • windows (2.4.x)
  • windows (2.5.x)
  • ubuntu (2.5.x, rubygems)
  • macos (2.6.x)

@ghost ghost merged commit 819c784 into master Jan 31, 2020
@ghost ghost deleted the colby/donation-uri branch January 31, 2020 07:36
@ioquatix
Copy link
Contributor

Just wondering, do I expect to see this on the sidebar on rubygems.org?

@colby-swandale
Copy link
Member Author

We haven't added a button to RubyGems.org yet. PRs welcome.

@gjtorikian
Copy link
Contributor

I've just opened a PR to add this: rubygems/rubygems.org#2522

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants