Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fx link in bundle-platform man page #6071

Merged
merged 1 commit into from
Nov 19, 2022

Conversation

chtitux
Copy link

@chtitux chtitux commented Nov 19, 2022

What was the end-user or developer problem that led to this PR?

At the end of the page https://bundler.io/man/bundle-platform.1.html , the link to bundle-lock(1) points to https://bundler.io/man/bundle-lock.1.ronn, which is not correct.

What is your fix for the problem, implemented in this PR?

Internal links should use .html extension, instead of .ronn.

Make sure the following tasks are checked

@welcome
Copy link

welcome bot commented Nov 19, 2022

Thanks for opening a pull request and helping make RubyGems and Bundler better! Someone from the RubyGems team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality.

We use GitHub Actions to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of GitHub Actions in the PR status window below.

If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #rubygems or #bundler channel on Slack.

For more information about contributing to the RubyGems project feel free to review our CONTRIBUTING guide

@deivid-rodriguez deivid-rodriguez changed the title man page: fix link in bundle-platform page Fx link in bundle-platform man page Nov 19, 2022
Copy link
Member

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this @chtitux!

@deivid-rodriguez deivid-rodriguez merged commit 47262c1 into rubygems:master Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants