Drop support for Ruby 2.3, 2.4, 2.5 and RubyGems 2.5, 2.6, 2.7 #6107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
drop-old-rubies-and-rubygems
branch
2 times, most recently
from
fca5e5a
to
0019b98
Compare
deivid-rodriguez
commented
Dec 9, 2022
| gem "bundler", Bundler::VERSION if Gem.rubygems_version < Gem::Version.new("2.6.2") | ||
|
|
||
| if Gem.rubygems_version < Gem::Version.new("3.2.3") && Gem.ruby_version < Gem::Version.new("2.6.a") && !ENV["BUNDLER_NO_OLD_RUBYGEMS_WARNING"] | ||
| if Gem.rubygems_version < Gem::Version.new("3.2.3") && Gem.ruby_version < Gem::Version.new("3.0.a") && !ENV["BUNDLER_NO_OLD_RUBYGEMS_WARNING"] |
There was a problem hiding this comment.
Ruby 3.0.0 ships with RubyGems 3.2.3. So next year we can drop support for Ruby 2.6 and Ruby 2.7 and we'll no longer need this warning.
deivid-rodriguez
force-pushed
the
drop-old-rubies-and-rubygems
branch
3 times, most recently
from
e98d4fc
to
bca5b23
Compare
deivid-rodriguez
force-pushed
the
drop-old-rubies-and-rubygems
branch
from
bca5b23
to
77e7b79
Compare
simi
reviewed
Dec 10, 2022
To not shadow `Kernel#p`.
deivid-rodriguez
force-pushed
the
drop-old-rubies-and-rubygems
branch
from
f035ad6
to
17f746f
Compare
simi
approved these changes
Dec 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
We've been warning when running Bundler on old RubyGems if running on Ruby 2.3, Ruby 2.4 and Ruby 2.5 for a year.
Hopefully that has given most folks sufficient head ups about our intention, although I can still imagine some disruption in some cases. Yet, we need to do this at some point, let's use new year's release to do it.
What is your fix for the problem, implemented in this PR?
Drop support for Ruby 2.3, 2.4 and 2.5, and RubyGems 2.5, 2.6 and 2.7.
There's a bunch of follow up PRs after this like
RuboCop style,bumping development dependencies, or bumping vendored gems. But I'll do that as follow up PRs.EDIT: I'm also normalizing RuboCop styles in this PR to make CI happy.
Make sure the following tasks are checked