Fix display of previous gem version when previously downloaded already #6110
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
bundle update
is no longer showing the green(was: x.y.z)
suffix for updated gems that were already installed (eg: by another app).This displayed in bundler <= 2.3.13 and went missing in 2.3.14.
What is your fix for the problem, implemented in this PR?
This PR reenables the "was..." suffix, which matches what was displayed both in bundler <= 2.3.13 and as still displayed in the current version for newly downloaded gems and for sources other than Rubygems.
In <= 2.3.13 and again with this PR:
In 2.3.14+:
Background
A number of changes surrounding tracking of the previous gem version were made in #5530, which was part of bundler 2.3.14. It appears those changes simply missed passing the previous spec info to the newly enhanced
version_message
method in the described case.Make sure the following tasks are checked