Auto-heal lockfile when it's missing specs #6132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
fix-crash-when-lockfile-missing-deps
branch
from
f28ee1d
to
15eaa47
Compare
deivid-rodriguez
force-pushed
the
fix-crash-when-lockfile-missing-deps
branch
from
15eaa47
to
7c4bd0c
Compare
|
We also clarified how this lockfile was generated. @ThaiGQ had a number of Now Bundler will be resilient to this kind of user error 💪. |
|
Nice work! |
|
Thanks for investigating and fixing the issue @deivid-rodriguez ! 🙏 |
|
We have said “there is no such thing as user error, only a bug in the Bundler UX” since the very beginning, all the way back in 2009. Major props to @deivid-rodriguez for doing such a good job with this one! 👏🏻 |
We have a check for a corrupt lockfile right before installing. However, the check accounted for locked specs not satisfying locked dependencies, but not for locked specs missing for some locked dependencies. Instead of fixing this check, I decided to remove it in favor of automatically detecting the situation and re-resolve to automatically fix the lockfile rather than printing a warning but leave the problem there.
deivid-rodriguez
force-pushed
the
fix-crash-when-lockfile-missing-deps
branch
from
7c4bd0c
to
4a7a584
Compare
|
Going in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
If a lockfile is missing some specs (meaning, it includes some dependencies but not specs for those dependencies), then Bundler currently happily accepts the lockfile and crashes when it's about to install it.
We have a check for a corrupt lockfile right before installing. However, the check accounted for locked specs not satisfying locked dependencies, but not for locked specs missing for some locked dependencies.
I still need to investigate why this kind of lockfile was generated in the first place, but that shouldn't block this PR.
What is your fix for the problem, implemented in this PR?
Instead of fixing this check, I decided to remove it in favor of automatically detecting the situation and re-resolve to automatically fix the lockfile rather than printing a warning but leave the problem there.
Fixes #6124.
Make sure the following tasks are checked