-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn --ext
option of bundle gem
into string. Deprecate usage without explicit value.
#6144
Conversation
85d613f
to
3c5379c
Compare
# when deprecated version of `--ext` is called | ||
# print out deprecation warning and pretend `--ext=c` was provided | ||
if deprecated_ext_value?(arguments) | ||
SharedHelpers.major_deprecation 2, "Option `--ext` without explicit value is deprecated. Please pass value like `--ext=c` for C extension. Pretending `--ext=c` was used for now." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll appreciate any suggestion of better text in here. pray
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SharedHelpers.major_deprecation 2, "Option `--ext` without explicit value is deprecated. Please pass value like `--ext=c` for C extension. Pretending `--ext=c` was used for now." | |
SharedHelpers.major_deprecation 2, "Extensions can now be generated using C or Rust, so `--ext` with no arguments has been deprecated. Please select a language, e.g. `--ext=rust` to generate a Rust extension. This gem will now be generated as if `--ext=c` was used." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll use this for the final one (other PR onboarding Rust gem generator).
🤔 locally |
Perhaps this branch needs to be rebased? GitHub says it is out of date. |
c0ed5c9
to
167ebb2
Compare
- this is preparation for onboarding Rust based extension gem generator
--ext
option into string. Deprecate usage without explicit value.--ext
option of bundle gem
into string. Deprecate usage without explicit value.
--ext
as much as possiblebundle gem --rust
command #5613Personally I used to create gems with
bundle gem --ext hello
. Now it prints deprecation when extension type is not provided explicitly, but continues with C extension.