Don't unlock dependencies of a gemspec when its version changes #6184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the case of a gemspec changing for example its version number, there was a comment about needing to unlock the gem. However, we were going directly to process the next spec without unlock it, nor adding it to the list of `converged` specs (which is what allows its dependencies to be processed when finding the set of locked specs that should be passed to the resolver). This commit adds the spec to the `@unlock[:gems]` array explicitly, and removes the `next` so that the logic to add it to the `converged` set also applies here.
deivid-rodriguez
changed the title
simi
approved these changes
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
When working with a gem locally with a Gemfile like
Changing the version in the
.gemspecfile and runningbundle installresults in dependencies defined in the gemspec being unlocked and possibly bumped in theGemfile.lockfile.What is your fix for the problem, implemented in this PR?
My fix is to accomodate the logic for finding the set of specs that need to be locked during resolution to do the right thing in this situation.
Fixes #6182.
Make sure the following tasks are checked