Fix bundle lock --update --bundler
#6213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
fix-bundle-lock-update-bundler
branch
2 times, most recently
from
46ec77e
to
5826021
Compare
deivid-rodriguez
force-pushed
the
fix-bundle-lock-update-bundler
branch
5 times, most recently
from
e4eb614
to
d3c11a1
Compare
We currently force the running version. But we will be allowing Bundler to be considered as just another gem later, so that `bundle lock --update --bundler` can actually work.
It's unclear why Ruby version is locked, whey they run `bundle update --bundler`, and they don't explicitly check that the proper versions get installed. In addition to that, I think the frozen case is just working accidentally because upgrading Bundler in frozen mode should fail unless Bunder is already up to date. Make the specs more explicit.
deivid-rodriguez
force-pushed
the
fix-bundle-lock-update-bundler
branch
from
d3c11a1
to
19416bd
Compare
deivid-rodriguez
added a commit
that referenced
this pull request
Jun 27, 2023
Fix `bundle lock --update --bundler` (cherry picked from commit dca5343)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
bundle lock --update --bundleris not working as expected, the lockfile is not updated.What is your fix for the problem, implemented in this PR?
Make the proper changes to allow resolving the version of Bundler itself (and not always resolving to the running version).
Fixes #6195.
Make sure the following tasks are checked