Fix several typos #6224
Fix several typos #6224
Conversation
|
Thanks for opening a pull request and helping make RubyGems and Bundler better! Someone from the RubyGems team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality. We use GitHub Actions to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of GitHub Actions in the PR status window below. If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #rubygems or #bundler channel on Slack. For more information about contributing to the RubyGems project feel free to review our CONTRIBUTING guide |
There was a problem hiding this comment.
Thanks!
Can you contribute fixes to bundler/lib/bundler/vendor/thor/ files to the upstream repository?
Also, how did you find all these? We used to have a spell checker in CI, but it never found any issues and I removed it.
Yup! I'll work on moving those upstream. I have removed them from the PR here so this only includes non-vendored files.
I used codespell. I believe Rails also uses this tool. |
|
Thor PR opened at: |
|
Should we onboard this tool as well? |
|
Definitely! For what it's worth, we did have spell checking in CI for about a year, but I removed it because the one time the CI check showed as failed, it was because the action failed to install, not because of detecting any typos. This one seems very easy to setup: https://github.com/codespell-project/actions-codespell. We could try if it detects a fair amount of the typos being fixed here. |
|
I went ahead and added a GitHub actions for codespell. This should catch future misspellings. |
| filetest | ||
| fo | ||
| hax | ||
| msdos |
Fix several typos (cherry picked from commit 2ae2926)
No description provided.