Fallback to selecting installable candidates if possible when materializing specs #6225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
changed the title
deivid-rodriguez
force-pushed
the
fix-upgrading-ruby-issue
branch
from
c23ed1e
to
05fbc70
Compare
When running in legacy lockfile mode (only RUBY platform in lockfile), it could happen that a specific candidate for the current platform is selected that's not actually installable for the current Ruby due to not matching Ruby version requirements. Check this case before hand so that we can use the generic version instead.
deivid-rodriguez
force-pushed
the
fix-upgrading-ruby-issue
branch
from
05fbc70
to
bb44a3c
Compare
deivid-rodriguez
added a commit
that referenced
this pull request
Jan 6, 2023
Fallback to selecting installable candidates if possible when materializing specs (cherry picked from commit 6c979fa)
hsbt
pushed a commit
that referenced
this pull request
Jun 1, 2023
Instead of resolving to correct Ruby platform, it preferred the archful package, that is actually incompatible. See sclorg/s2i-ruby-container#469 for an example of the bug. Commit taken from: <#6225> and adapted: <7b64c64> for the PR#6225.
hsbt
pushed a commit
that referenced
this pull request
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
When running in legacy lockfile mode (only RUBY platform locked in Gemfile.lock), it may happen that we select a platform specific version, only to later find that it's not installable because of not matching ruby version requirements.
This is the case when having
nokogiri-1.3.10in this kind of lockfile. This version ofnokogirionly supports Ruby 3.2 in its generic version (though a "Ruby >= 2.6" requirement), but there are no yet precompiled versions for Ruby 3.2, so those don't support Ruby 3.2 (they use a ">= 2.6, < 3.2.DEV" requirement).So when upgrading such a lockfile to Ruby 3.2, we would incorrectly select a precompiled version, and fail to materialize it.
What is your fix for the problem, implemented in this PR?
Check the above situation before-hand so that we can fallback to the generic version.
Closes #6221.
Make sure the following tasks are checked