Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When auto-removing RUBY platform don't add specific platform if not needed #6233

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

deivid-rodriguez
Copy link
Member

What was the end-user or developer problem that led to this PR?

Sometimes, Bundler removes RUBY platform from the Gemfile.lock because it needs to, but it also adds the current specific platform to it, when it's not necessary.

What is your fix for the problem, implemented in this PR?

If there's a more specific platform than "ruby", but more generic that the current specific platform, leave that one in the lockfile and don't add the specific platform to it.

Fixes #6232.

Make sure the following tasks are checked

@deivid-rodriguez deivid-rodriguez force-pushed the fix-unnecessary-specific-platform-added branch from 69857d6 to c9796bf Compare January 5, 2023 06:27
@deivid-rodriguez deivid-rodriguez merged commit 17f1293 into master Jan 5, 2023
@deivid-rodriguez deivid-rodriguez deleted the fix-unnecessary-specific-platform-added branch January 5, 2023 09:25
deivid-rodriguez added a commit that referenced this pull request Jan 6, 2023
…orm-added

When auto-removing RUBY platform don't add specific platform if not needed

(cherry picked from commit 17f1293)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bundle upgrade after bundler update unnecessarily adds version-specific current platform to lock file
1 participant