Cleanup unnecessary gems when removing lockfile platforms #6234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
cleanup-unnecessary-gems-when-removing-platforms
branch
from
45eee4a
to
20e4e0c
Compare
deivid-rodriguez
force-pushed
the
cleanup-unnecessary-gems-when-removing-platforms
branch
from
20e4e0c
to
1b7bdaa
Compare
deivid-rodriguez
deleted the
cleanup-unnecessary-gems-when-removing-platforms
branch
deivid-rodriguez
added a commit
that referenced
this pull request
Jan 6, 2023
…removing-platforms Cleanup unnecessary gems when removing lockfile platforms (cherry picked from commit 6ba790c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
When removing lockfile platforms, unnecessary lockfile gems are not cleaned up, and then they are confusingly lost in subsequent commands.
This used to work fine, but when we introduced #5695 for speed, this feature was lost.
What is your fix for the problem, implemented in this PR?
Restore the feature by remembering when platforms have been removed, so that we don't reintroduce any performance penalty in the general case.
Fixes #6231.
Make sure the following tasks are checked