Fix pointing GitHub sources to PRs #6241
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Recent refactorings in git sources to use shallow clones when possible broke pointing to GitHub PRs.
Git sources are now more strict and require that the parameter the
:branch
to be an actual branch, and the parameter to:tag
to be an actual branch. For arbitrary refs, which is what pointing to GitHub pull requests use under the hood,ref
should be used.What is your fix for the problem, implemented in this PR?
This PR changes Bundler to use
ref
internally for handling PR URLs given as the value for the:github
parameter.Fixes #6239.
Make sure the following tasks are checked