Skip setting BUNDLER_SETUP on Ruby 2.6
#6252
Conversation
deivid-rodriguez
force-pushed
the
skip-setting-bundler-setup-on-ruby-2.6
branch
from
6a41632
to
768c2a3
Compare
|
🤔 Was #6025 just forgotten? I think we all agreed that was mistake to merge. |
|
@mame and @hsbt were fine with merging and shipping it. Nobody answered my request for a revert, and I couldn't find a strong reason to block it unilaterally other than "it feels wrong", so I did not proceed with the revert myself. So, to answer your question, no, I personally did not forget. At this point I'm not sure we should revert the feature. People may be already using it, since we have released it. That's why I went with reverting it for Ruby 2.6 to fix this particular issue as the least controversial thing to do. |
|
I will merge this, since whatever we discuss around this issue should not block fixing #6251. |
deivid-rodriguez
force-pushed
the
skip-setting-bundler-setup-on-ruby-2.6
branch
from
768c2a3
to
2abae4c
Compare
|
Thanks. I try to replace it with other approach. But I'm not sure when it's done. I'm +1 to skip it on Ruby 2.6. |
…ruby-2.6 Skip setting `BUNDLER_SETUP` on Ruby 2.6 (cherry picked from commit 17b4977)
What was the end-user or developer problem that led to this PR?
Setting
BUNDLER_SETUPonbundle execso that RubyGems can setup the bundle early in the subprocess breaks loading DidYouMean on Ruby 2.6, since it was a bundled (not default) gem there, and thus gets "erased" bybundler/setup.What is your fix for the problem, implemented in this PR?
Skip this feature on Ruby 2.6.
Closes #6251.
Make sure the following tasks are checked