Fix another case of not properly falling back to ruby variant when materializing #6261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
fix-another-materialization-issue
branch
from
a8fdf48
to
6b57da4
Compare
It makes spec wording unnecessarily verbose and some of the specs here don't need setting the platform at all and are unrelated to MacOS.
…date In this case, when materializing a legacy lockfile using only "ruby" platform, and in frozen mode.
In particular, why we may materialize a non-installable gem in frozen mode.
deivid-rodriguez
force-pushed
the
fix-another-materialization-issue
branch
from
6b57da4
to
7c43752
Compare
deivid-rodriguez
added a commit
that referenced
this pull request
Jan 13, 2023
Fix another case of not properly falling back to ruby variant when materializing (cherry picked from commit f2084b1)
CvX
added a commit
to CvX/licensed
that referenced
this pull request
Jan 17, 2023
…to fix bundler 2.4.4 incompatiblity rubygems/rubygems#6261 changed the arity of `__materialize__` method again, which broke `licensed` See also: github#522 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
In rubygems/rubygems.org#3332, another case where Bundler is not properly falling back to the generic version of nokogiri was surfaced. It's very similar to #6221, but in frozen mode.
What is your fix for the problem, implemented in this PR?
My fix is to not materialize to a non installable version in frozen mode when verifying whether we need to fallback to the generic platform.
Make sure the following tasks are checked