Properly handle incompatibilities on platform specific gems #6270
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
When creating incompatibilities for requirements with no matching versions here:
rubygems/bundler/lib/bundler/resolver.rb
Lines 154 to 176 in 9abd8ac
We receive a pub grub version range, and need to convert it to a "standard" requirement. We parse the string representation of the version range for that. However, if the version range includes platform specific candidates, those were include the platform under parenthesis, making the string representation unparseable.
What is your fix for the problem, implemented in this PR?
To fix the bug, we use only the string representation of the underlying version as the string representation of a candidate. Error messages already include the resolution platforms separately so it should not degrade with end users see or make any messages less clear.
Fixes #6267.
Make sure the following tasks are checked