Update bundle-exec man page to not use deprecated Bundler.with_clean_env
#6284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
approved these changes
Jan 20, 2023
There was a problem hiding this comment.
We should probably document Bundler.with_original_env, and the differences between the two (in my experience Bundler.with_original_env is normally what users want).
But this first pass replacing the deprecated helper with the non-deprecated equivalent already improves things, so good to go as is!
`with_clean_env` has been deprecated in `with_unbundled_env`. It already generates a deprecation warning when it uses, but this man page was still referring to it.
deivid-rodriguez
force-pushed
the
bundle-with-unbundled-env-docs
branch
from
916e089
to
769dce1
Compare
deivid-rodriguez
changed the title
Bundler.with_clean_env
deivid-rodriguez
added a commit
that referenced
this pull request
Jan 21, 2023
…env-docs Update bundle-exec man page for with_unbundled_env (cherry picked from commit 0688951)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with_clean_envhas been deprecated inwith_unbundled_env. It already generates a deprecation warning when it uses, but this man page was still referring to it.What was the end-user or developer problem that led to this PR?
If a user follows the instructions from
bundle exec --helpand usesBundler.with_clean_env, they will get a deprecated message to useBundler.with_unbundled_envWhat is your fix for the problem, implemented in this PR?
Update the .ronn and .man pages
Make sure the following tasks are checked