Fix bundler/inline not skipping installation when gems already there, when used more than once
#6305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for fixing these things! Can you move the fix related to extensions to a separate PR? That way we can ship the first fix which seems ready to go with a test, and then focus on reproducing/fixing the other issue. |
tbates-redarc
force-pushed
the
inline-reinstall-fix
branch
from
106087a
to
96c48ea
Compare
tbates-redarc
force-pushed
the
inline-reinstall-fix
branch
from
96c48ea
to
5f171fe
Compare
|
Moved second commit to #6306 and fixed unit tests. |
deivid-rodriguez
changed the title
bundler/inline not skipping installation when gems already there, when used more than once
deivid-rodriguez
pushed a commit
that referenced
this pull request
Jan 31, 2023
Fix `bundler/inline` not skipping installation when gems already there, when used more than once (cherry picked from commit a9c9ea2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Using
bundler/inlinemultiple times causes gems mentioned in the second and subsequent uses to be reinstalled on every invocation, even if they were already installed.What is your fix for the problem, implemented in this PR?
Bundler.reset!togemfilemethod which fixes the problem, but I am not sure if this is the correct approach.I had another problem that I can't work out how to write a test for, where extensions were not being compiled correctly when installed in this manner. Wrapping the body of the(Moved to Fixgemfilemethod inBundler.with_unbundled_envfixed it.bundler/inlinenot properly installing gems with extensions when used more than once #6306)Make sure the following tasks are checked