Don't warn on bundle binstubs --standalone --all
#6312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit `bundle binstubs --standalone --all` would output a warning about not being able to generate a standalone binstub for bundler. This warning predates the `--all` option, and I don't think it makes sense in this context. The warning makes good sense when explicitly trying to generate a bundler standalone binstub with `bundle binstubs bundler --standalone`, since that command won't do what the user might have expected. But `--all` is not specifically asking for bundler, and having it report each time that the bundler binstubs could not be generated does not seem particularly helpful. The only way to make that warning go away would be to stop using `--standalone --all`. This commit skips the warning when running with the `--all` option.
deivid-rodriguez
approved these changes
Jan 27, 2023
deivid-rodriguez
changed the title
bundle binstubs --standalone --all
deivid-rodriguez
pushed a commit
that referenced
this pull request
Jan 31, 2023
Don't warn on `bundle binstubs --standalone --all` (cherry picked from commit be1cc4a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Prior to this commit
bundle binstubs --standalone --allwould output a warning about not being able to generate a standalone binstub for bundler.This warning predates the
--alloption, and I don't think it makes sense in this context. The warning makes good sense when explicitly trying to generate a bundler standalone binstub withbundle binstubs bundler --standalone, since that command won't do what the user might have expected. But--allis not specifically asking for bundler, and having it report each time that the bundler binstubs could not be generated does not seem particularly helpful. The only way to make that warning go away would be to stop using--standalone --all.What is your fix for the problem, implemented in this PR?
This commit skips the warning when running with the
--alloption.Make sure the following tasks are checked