Preserve relative path sources in standalone setup #6327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What was the end-user or developer problem that led to this PR? -- Fixes rubygems#5317 When specifying gems with the `:path` option, `bundler --standalone` generates a `bundler/setup.rb` with absolute paths for those gems. This makes good sense when the `:path` is absolute (the behavior was explicitly added in rubygems#4792 to handle absolute paths). But when the `:path` option is relative, it is not always desirable to have absolute paths in `bundler/setup.rb`. For example, I work on an application that runs `bundler --standalone` in CI to build a deploy artifact, but because the root directory in CI does not match the root in production we are unable to use the generated bundler/setup.rb directly. What is your fix for the problem, implemented in this PR? -- This commit reverts back to bundler-setup-relative paths in if the `:path` option is relative. It preserves the current behavior of using absolute paths only when the `:path` option is absolute.
deivid-rodriguez
approved these changes
Jan 31, 2023
deivid-rodriguez
pushed a commit
that referenced
this pull request
Feb 15, 2023
…aths Preserve relative path sources in standalone setup (cherry picked from commit 9f8bae3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Fixes #5317
When specifying gems with the
:pathoption,bundler --standalonegenerates abundler/setup.rbwith absolute paths for those gems.This makes good sense when the
:pathis absolute (the behavior was explicitly added in #4792 to handle absolute paths).But when the
:pathoption is relative, it is not always desirable to have absolute paths inbundler/setup.rb. For example, I work on an application that runsbundler --standalonein CI to build a deploy artifact, but because the root directory in CI does not match the root in production we are unable to use the generated bundler/setup.rb directly.What is your fix for the problem, implemented in this PR?
As suggested in #5317 (comment), this commit reverts back to bundler-setup-relative paths in if the
:pathoption is relative. It preserves the current behavior of using absolute paths only when the:pathoption is absolute.Make sure the following tasks are checked