-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better deal with circular dependencies #6330
Conversation
This reverts commit a8348d2, and introduces the alternative approach of ignoring this kind of candidate.
802e106
to
e9d761c
Compare
Spec added! |
Actually let me try a slightly better approach. |
851f3f4
to
fe4a62f
Compare
Alright so the new approach is:
We should probably raise a validation warning on |
I also proposed a similar change upstream. |
🤔 I can take over to introduce gemspec validations once merged. |
Better deal with circular dependencies (cherry picked from commit a1ba9f1)
What was the end-user or developer problem that led to this PR?
When a dependency includes a version with circular dependencies, and the resolver ends up considering it, it gives up with a confusing error.
What is your fix for the problem, implemented in this PR?
Ignore these ill-defined versions.
Fixes #6328.
Make sure the following tasks are checked