Replace "prior to" with "immediately after" in bundle gem generated README file
#6338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sambostock
changed the title
bundle gem README.md.tt
|
Would you mind to add this to this list next to the old name as well @sambostock? |
sambostock
added a commit
to sambostock/rubygems.org
that referenced
this pull request
Feb 4, 2023
We must reserve the new placeholder, updated in rubygems/rubygems#6338.
|
@simi done in rubygems/rubygems.org#3392 |
sambostock
force-pushed
the
tweak-bundle-gem-readme-placeholder
branch
from
560fa87
to
dabece5
Compare
Currently, the instructions and placeholder contradict each other. The commit that introduced this placeholder (42bc471) makes it clear that the placeholder should be replaced AFTER publishing (i.e. once the author successfully claims the gem name on Rubygems), so the placeholder should match.
sambostock
force-pushed
the
tweak-bundle-gem-readme-placeholder
branch
from
dabece5
to
23e2dea
Compare
|
I'll merge once the change is deployed to rubygems.org. ℹ️ UPDATE: deployed |
deivid-rodriguez
changed the title
bundle gem README.md.ttbundle gemgenerated README file
deivid-rodriguez
changed the title
bundle gemgenerated README filebundle gem generated README file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Currently, the instructions and placeholder contradict each other.
The commit that introduced this placeholder (42bc471) makes it clear that the placeholder should be replaced AFTER publishing (i.e. once the author successfully claims the gem name on Rubygems), so the placeholder should match.
What is your fix for the problem, implemented in this PR?
The placeholder is updated.
Make sure the following tasks are checked
Write tests for features and bug fixesWrite code to solve the problemMake sure you follow the current code style and write meaningful commit messages without tags