Make gemspec file generated by bundle gem properly exclude itself from packaged gem
#6339
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous code loads bundler's gemspec which does not include the generated gemspec file, and thus the test was passing where it should indeed fail. With this change, the test properly fails now.
by comparing the file names with full path. Follows up f444478
deivid-rodriguez
approved these changes
Feb 6, 2023
deivid-rodriguez
changed the title
bundle gem properly exclude itself from packaged gem
deivid-rodriguez
added a commit
that referenced
this pull request
Feb 15, 2023
Exclude gemspec file itself from gem (take 2) (cherry picked from commit 9c953a5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch follows up f444478 by @nobu
What was the end-user or developer problem that led to this PR?
There used to be a commit f444478 that intended to exclude the gemspec file from gem package, but the gemspec file is in fact still included in gems that we build today, even though the test included in that commit (that asserts it "does not include the gemspec file in files") is passing.
This was because:
What is your fix for the problem, implemented in this PR?
This patch fixes both broken test and the newgem template. Now the gemspec file should be properly excluded as intended.
Make sure the following tasks are checked