Use RbSys::ExtensionTask when creating new rust gems
#6352
Conversation
ianks
added
Bundler
bundler: enhancement
rust
There was a problem hiding this comment.
👍 I confirmed to usage for rb_sys/extensiontask via https://github.com/oxidize-rb/rb-sys/tree/main/gem#rbsysextensiontask
|
|
||
| task build: :compile | ||
|
|
||
| RbSys::ExtensionTask.new(<%= config[:name].inspect %>) do |ext| |
There was a problem hiding this comment.
@ianks
Don't need to pass gemspec here? According to the document, it requires here.
https://github.com/oxidize-rb/rb-sys/tree/main/gem#rbsysextensiontask
If my understanding is correct, it is needed to check some data in the gemspec.
https://github.com/oxidize-rb/rb-sys/blob/dfc51c60bef89925bfded1713e9ec02c5dfb639d/gem/lib/rb_sys/extensiontask.rb#L139-L149
There was a problem hiding this comment.
it's needed for cross-compilation, but it's optional. Probably a good idea to add it though.
There was a problem hiding this comment.
Thanks. I understood the intent. I was curious because using RbSys::ExtensionTask without gemspec raises an error now. It seems it's not intended so I will create a patch to rb-sys.
There was a problem hiding this comment.
Use `RbSys::ExtensionTask` when creating new rust gems (cherry picked from commit 6a62e46)
This PR makes it so
bundle gem --ext=rustwill useRbSys::ExtensionTask. This is a thin wrapper overRake::ExtensionTask, which is tailored for Rust and addresses a number of shortcomings of using the default configuration. Namely:targetdirectories (reducing compilation times and cache bloat)cargo metadatato find extension dir (similar to @matsadler PR).Links