Improve solve failure explanations by using better wording #6366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Replaces the wording of "is forbidden" with "cannot be used" * Fixes the method signature of VersionRange::Empty#eql? Co-authored-by: Daniel Colson <danieljamescolson@gmail.com>
simi
approved these changes
Feb 11, 2023
deivid-rodriguez
changed the title
|
Let's see how merge queue behaves on potentially conflicting PRs. |
deivid-rodriguez
approved these changes
Feb 13, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
deivid-rodriguez
added a commit
that referenced
this pull request
Feb 15, 2023
Improve solve failure explanations by using better wording (cherry picked from commit 855991c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VersionRange::Empty#eql?Fixes ArgumentError: wrong number of arguments (given 1, expected 0) #6326