Fix gems.rb
lockfile for bundler version lookup in template
#6413
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
When I create a rails 7 project with
rails new my_app --minimal
, there are a couple of files underbin
provided from bundler.bin/bundle
caught my attention withThis line:
when "gems.rb" then gemfile.sub(/\.rb$/, gemfile)
When provided with
gems.rb
, the lockfile ends up becomegemsgems.rb
, which is very likely that the file is missing and this expression is returningfalse
and prevent reading bundler version from the lockfile.I noticed that the filename(
Gemfile
/gems.rb
,Gemfile.lock
/gems.locked
) is probably not that important, since the content is the same, but Bundler has a specific mapping forgems.rb
togems.locked
I think should be respected.What is your fix for the problem, implemented in this PR?
The fix changes the lockfile lookup for
gems.rb
during bundler version lookup. Respect the bundler version specified ingems.locked
.Make sure the following tasks are checked