-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-heal corrupted Gemfile.lock
with no specs
#6423
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
4 tasks
I rebased off #6400, which is in the merge queue already. Once that's merged, I'll rebase off master again. |
Is it ready for a review now @duckinator? It looks good to me! |
Yeah, this is good to go. Just forgot to switch it from draft to normal PR. I'm not at a computer atm, so you can go ahead and do that then merge it.
…On Wed, Mar 1, 2023, at 9:04 AM, David Rodríguez wrote:
Is it ready for a review now @duckinator <https://github.com/duckinator>? It looks good to me!
—
Reply to this email directly, view it on GitHub <#6423 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAJWESY6ICHAST5UQJ5YDDWZ5JOLANCNFSM6AAAAAAVLMRA4Q>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
deivid-rodriguez
changed the title
Avoid NoMethodError with malformed Gemfile.lock. (v2)
Auto-heal corrupted Mar 1, 2023
Gemfile.lock
with no specs
deivid-rodriguez
approved these changes
Mar 1, 2023
Done! Thanks for this @duckinator! |
deivid-rodriguez
added a commit
that referenced
this pull request
Mar 8, 2023
Auto-heal corrupted `Gemfile.lock` with no specs (cherry picked from commit 131085f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
If a Gemfile.lock has a mismatch between
specs:
andDEPENDENCIES
, printing funding information runs what boils down tonil.metadata
. This caused aNoMethodError
to be raised.What is your fix for the problem, implemented in this PR?
If the lockfile is malformed, it should be regenerated.
Make sure the following tasks are checked