Don't ignore pre-releases when there's only one candidate #6441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be a very rare edge case, however, it does happen when using a .dev version of Bundler because in that case, that's the only version that the resolver considers, and it should not be ignored. We could've special cased this specifically for Bundler, but I think it does make sense for every gem.
deivid-rodriguez
added a commit
that referenced
this pull request
Mar 20, 2023
Don't ignore pre-releases when there's only one candidate (cherry picked from commit 5cf7094)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
While playing around with the latest (master) branch of Bundler, I found a surprising behavior: a simple Gemfile including only "rails" resolves to Rails 2.3.18 (10 years old!) 馃槷.
What is your fix for the problem, implemented in this PR?
Turns out the issue was introduced by #6246.
Since Bundler 2.5.0.dev is a pre-release version, Bundler actually ignores it and tries to find a resolution that does not have any dependency on Bundler, and Rails 2.3.18 satisfies that.
I could've special cased this specifically for Bundler, but I think it does make sense for every gem to not ignore prereleases if the resolver is considering a single version of that gem.
Make sure the following tasks are checked