Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicated specs in some error messages #6475

Merged
merged 6 commits into from
Mar 15, 2023
Merged

Conversation

deivid-rodriguez
Copy link
Member

What was the end-user or developer problem that led to this PR?

Sometimes, when using lockfiles with multiple platforms locked, you may end up with an error messages that mentioned duplicated gems, like

Could not find rack-0.9.1, rack-0.9.1 in locally installed gems
Install missing gems with `bundle install`.

What is your fix for the problem, implemented in this PR?

Fix the issue by deduplicating specs.

I also included some other minor spec improvements.

Make sure the following tasks are checked

@deivid-rodriguez deivid-rodriguez added this pull request to the merge queue Mar 15, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 15, 2023
@deivid-rodriguez deivid-rodriguez added this pull request to the merge queue Mar 15, 2023
Merged via the queue into master with commit fb22660 Mar 15, 2023
@deivid-rodriguez deivid-rodriguez deleted the dup-specs branch March 15, 2023 21:47
deivid-rodriguez added a commit that referenced this pull request Mar 20, 2023
Fix duplicated specs in some error messages

(cherry picked from commit fb22660)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant