Don't recommend --full-index on errors
#6493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simi
approved these changes
Mar 16, 2023
deivid-rodriguez
removed this pull request from the merge queue due to a manual request
|
I think we need https://github.com/ruby/setup-ruby/releases/tag/v1.144.1 to fix the mswin build. Will add it to this PR. |
|
I created a separate PR to bump the |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
The debug message suggests retrying using `--full-index`, but the retry is happening automatically. Just log that we are falling back to the full index, like we do with other errors.
We're actually already using the full index here, so it makes no sense to suggest retrying the same thing.
I've never seen this error in real life, and if it was happening, I think it's either some server side issue that would need to be fixed or some transient issue. We should move away from the full index, since it's slow, so let's stop recommending it.
deivid-rodriguez
force-pushed
the
dont-recommend-full-index
branch
from
320141c
to
848f445
Compare
deivid-rodriguez
added a commit
that referenced
this pull request
Mar 20, 2023
Don't recommend `--full-index` on errors (cherry picked from commit d5b20aa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
The
--full-indexflag is slow since the resolver needs to fetch the remote gemspec every time it needs to figure out dependencies of a gem, which happens a lot during resolution.Plus it's still potentially vulnerable to dependency confusion issues.
Also, some of this recommendations did not even make sense as far as I understand.
Finally these days the dependency APIs are reliable enough, and there are implicit fallbacks in place anyways.
What is your fix for the problem, implemented in this PR?
Stop recommending
--full-index.Make sure the following tasks are checked