Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore "enumerability" of SpecSet #6532

Merged
merged 2 commits into from
Mar 23, 2023

Conversation

deivid-rodriguez
Copy link
Member

What was the end-user or developer problem that led to this PR?

In #6495 I made SpecSet no longer behave as a "sane" enumerable.

What is your fix for the problem, implemented in this PR?

Since the commits that broke that were just refactoring commits not necessary for the bug fixes in #6495, I will revert them until I find time to properly address this.

Fixes #6528.

Make sure the following tasks are checked

@deivid-rodriguez deivid-rodriguez added this pull request to the merge queue Mar 23, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 23, 2023
@deivid-rodriguez deivid-rodriguez merged commit 4d35dd4 into master Mar 23, 2023
@deivid-rodriguez deivid-rodriguez deleted the incomplete-specs-missing-methods branch March 23, 2023 17:18
deivid-rodriguez added a commit that referenced this pull request Mar 24, 2023
Restore "enumerability" of `SpecSet`

(cherry picked from commit 4d35dd4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bundler::SpecSet can break on iteration/array coercion after PR #6495
1 participant