Fix resolver hangs when dealing with an incomplete lockfile #6552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
deivid-rodriguez/more-definition-fixes
branch
from
af8a1ba
to
4ce9d0b
Compare
While working on locking multiple platforms by default, I got an infinite resolution loop in one of our resolver specs. The culprit ended up being that when dealing with lockfile specs with incomplete dependencies (spec appears in lockfile, but its dependencies don't), those specs were not being properly expired and that tripped up resolution. The issue for some reason only manifests when dealing with multiple lockfile platforms, that's why it only manifested when working on locking multiple platforms by default.
deivid-rodriguez
force-pushed
the
deivid-rodriguez/more-definition-fixes
branch
from
4ce9d0b
to
4ca7291
Compare
deivid-rodriguez
added a commit
that referenced
this pull request
Apr 10, 2023
…on-fixes Fix resolver hangs when dealing with an incomplete lockfile (cherry picked from commit 70ee041)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
While working on locking multiple platforms by default, I got an infinite resolution loop in one of our resolver specs.
The culprit ended up being that when dealing with lockfile specs with incomplete dependencies (spec appears in lockfile, but its dependencies don't), those specs were not being properly expired and that tripped up resolution.
The issue for some reason only manifests when dealing with multiple lockfile platforms, that's why it only manifested when working on locking multiple platforms by default.
What is your fix for the problem, implemented in this PR?
Properly expire lockfile specs incomplete in the way explained above, so that resolver does not get confused.
Make sure the following tasks are checked